Tighten invalid commons receipt fixtures (v1.1.0)#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
receipt.invalid.jsonfixtures underexamples/v1.1.0/commons/*/json/invalidto fail for a single, realistic reason (malformed hash pattern, malformed timestamp format, invalid signature pattern, or missing required top-level field).examples/v1.1.0/commons/analyze/json/invalid/900-invalid-request-hash.receipt.invalid.json,examples/v1.1.0/commons/clean/json/invalid/900-invalid-timestamp.receipt.invalid.json,examples/v1.1.0/commons/convert/json/invalid/900-invalid-signature.receipt.invalid.json,examples/v1.1.0/commons/convert/json/invalid/901-missing-request-hash.receipt.invalid.json,examples/v1.1.0/commons/describe/json/invalid/900-missing-status.receipt.invalid.json,examples/v1.1.0/commons/explain/json/invalid/900-missing-signature.receipt.invalid.json,examples/v1.1.0/commons/explain/json/invalid/901-invalid-request-hash.receipt.invalid.json,examples/v1.1.0/commons/fetch/json/invalid/900-invalid-result-hash.receipt.invalid.json,examples/v1.1.0/commons/parse/json/invalid/900-invalid-timestamp.receipt.invalid.json, andexamples/v1.1.0/commons/summarize/json/invalid/900-invalid-request-hash.receipt.invalid.json.Testing
node scripts/validate-all.mjsto compile/validate schemas and it completed successfully.node scripts/validate-examples.mjsand iterated until the example-suite validation passed; final run reports all v1.1.0 valid examples accepted and invalid examples rejected as expected.Codex Task