Add package-lock.json and switch CI to npm ci for validate workflow#8
Merged
Add package-lock.json and switch CI to npm ci for validate workflow#8
npm ci for validate workflow#8Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
npm cibut the repository had nopackage-lock.json, causing CI failures.npm cican install reproducibly without changing declared dependencies.Description
package-lock.jsonfor the current package so CI has a lockfile to consume.package-lock.jsonfrom.gitignoreso the lockfile can be tracked (.gitignoreupdated).npm cifor installation (.github/workflows/validate.ymlupdated).package-lock.json,.gitignore, and.github/workflows/validate.yml.Testing
npm install --package-lock-onlyto generate the lockfile (succeeded).npm ciagainst the repo using the new lockfile (succeeded).npm run validatewhich executes schema and example validation (all validations succeeded).git diff --checkwas run to ensure no whitespace/patch issues (no problems found), and the validate workflow should now pass usingnpm cibecause a committedpackage-lock.jsonis present.Codex Task