Remove tracked dist artifacts, drop legacy TS tests/sources, and fix AJV import for tsc#11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
dist/artifacts from source control so build outputs are not tracked and future PRs remain clean.ajvsonpm run buildandtscsucceed.Description
dist/and addeddist/to.gitignoreso distribution files are no longer included in the repo.src/receipt-v1.tsandsrc/test/runtime-core.test.tswhich were superseded by the modern sources and tests.src/schema-client.tsto cast the dynamically importedajvdefault export to a constructor (AjvCtor) and instantiate it vianew AjvCtor(...)to resolve the TS constructability error.src/shims.d.tsand leftsrc/canonicalize.tspresent as required.Testing
npm installwhich failed in this environment due to a registry403 Forbiddenerror when fetching@types/node, so full install of dev/test deps did not complete.npm run buildwhich succeeded after theajvimport/instantiation fix, resolving the earlier TS error.npm testwhich failed due to missing test runtime helpertsx/esm(transitively unavailable becausenpm installdid not complete).npm run typecheck(tsc --noEmit) which passed with the applied changes.Codex Task