Update ERC-8211 canonicalization from merkle to composable#27
Merged
Conversation
- Replace ERR_UNSUPPORTED_MERKLE_VERIFICATION with ERR_MERKLE_AUTHORIZATION_DEFERRED - Add comment: ERC-8211 composable execution canonicalization recognized; Merkle authorization verification is deferred pending companion ERC - Update test: canonicalization string, error code, and test description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the ERC-8211 canonicalization method from "erc8211.merkle.v1" to "erc8211.composable.v1" and adjusts the verification logic to defer Merkle authorization verification pending the companion Merkle authorization ERC specification.
Key Changes
"erc8211.merkle.v1"to"erc8211.composable.v1"in the verification options"erc8211.composable.v1"instead of"erc8211.merkle.v1"ERR_UNSUPPORTED_MERKLE_VERIFICATIONwithERR_MERKLE_AUTHORIZATION_DEFERREDto better reflect that Merkle authorization verification is intentionally deferred rather than unsupportedImplementation Details
The change maintains backward compatibility in the verification flow while updating the canonical method identifier. The error handling now explicitly indicates that Merkle authorization verification is deferred rather than unsupported, which better communicates the intended behavior as the ERC-8211 specification evolves.
https://claude.ai/code/session_01HQCtc5GNqzudgSrLxJby5H