Conversation
Why: add production-surface receipt/verify tests while removing the in-repo SDK subtree so this repo stays focused on the runtime service layer.\nContract impact: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
makeReceipt()signing path and thePOST /verifybehavior implemented inserver.mjsso the runtime's core signing+verification flow is covered by unit tests.sdk/.CHANGELOG.mddocumenting a crediblev1.0.0baseline and the current unreleased work for this change.Description
runtime/tests/runtime-signing.test.mjswith focused production-surface tests that exercisemakeReceipt()(via verb calls) andPOST /verifyfor wrapped and bare receipts, tamper detection, ENS-backed verification, andstrict_kidbehavior.sdk/typescript-sdk/tests/*.test.mjs) and updatedpackage.jsontest:unitto only run the runtime tests (node --test runtime/tests/*.test.mjs).CHANGELOG.mdat the repo root with anUnreleasedsection and a factualv1.0.0entry describing the runtime service, health endpoints, and/verify.server.mjsverification path and adjusted a brief comment in the legacyruntime/src/receipt-verification.jsto reflect remaining compatibility tests.Testing
node --check server.mjsandnpm run checkto validate syntax, which completed successfully.node --test runtime/tests/runtime-signing.test.mjs, which passed all subtests.npm run test:unit(now only runtime unit tests) andnpm test(unit tests +node tests/smoke.mjs), and both completed successfully with all tests and smoke checks passing.@commandlayer/runtime-corewas not pinned in this pass, per constraints.Codex Task