Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
receipt.x402.verbas primary and conflatingmetadata.receipt_idwith the payload hash, causing parsing and verification mismatches.receipt.verbis canonical andmetadata.proof.hash_sha256is the integrity hash whilemetadata.receipt_idis a distinct identifier.Description
receipt.verbas the canonical verb and keepreceipt.x402.verbonly as a documented legacy fallback via a newgetReceiptVerb()helper and updatedCanonicalReceipttyping.verifyReceipt()to validateproof.hash_sha256(recomputed from the unsigned canonical receipt) and the Ed25519 signature, and to stop requiringmetadata.receipt_id === proof.hash_sha256for success while reportingreceipt_id_presentand preserving the old equality check as a deprecated telemetry value.metadata.receipt_idfrom the signed payload and keephash_sha256as the integrity hash, with types and verification result fields adjusted (receipt_id_present, legacyreceipt_id_matches).receipt_id, examples printreceipt.verb, and tests cover the new default path plus an isolated legacyx402.verbfallback.Testing
npm run typecheckand TypeScript type checks completed successfully.npm run test:unit(build + unit tests + template tests) and all package-local unit and template tests passed.node --test tests/*.mjsandnode --test ../runtime/tests/*.mjsand all runtime-facing verification tests passed.receipt_idis present but not required to equal the signedhash_sha256as well as a legacy fallback test forx402.verb.“SDK receipt parsing and verification now matches / still does not match the runtime-aligned receipt contract.”
Codex Task