Add useTrackingDetails as sharable component#1077
Merged
Conversation
✅ Deploy Preview for commercelayer-app-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…se Modal instead of Overlay
gciotola
force-pushed
the
tracking-details-modal
branch
from
1fb1586 to
1d6bbcc
Compare
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extracts the shipment parcel tracking-details UI into a standalone useTrackingDetails hook so it can be reused outside of ResourceShipmentParcels, and switches the presentation from an Overlay to a Modal. It also adds a Storybook story demonstrating the new hook.
Changes:
- Added a new reusable
useTrackingDetailshook that renders tracking history inside aModal. - Updated
ResourceShipmentParcelsto use the new hook and modal-based UI. - Added a Storybook story and exported the hook from the package entrypoint.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/docs/src/stories/resources/useTrackingDetails.stories.tsx | Adds a Storybook example to open/inspect the tracking-details modal via the new hook. |
| packages/app-elements/src/ui/resources/useTrackingDetails.tsx | Introduces the reusable hook + modal UI for tracking history/details. |
| packages/app-elements/src/ui/resources/ResourceShipmentParcels.tsx | Replaces the previous internal overlay implementation with the new shared hook/modal. |
| packages/app-elements/src/main.ts | Exports useTrackingDetails from the library entrypoint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ble right slot content
pfferrari
previously approved these changes
Apr 14, 2026
malessani
previously approved these changes
Apr 14, 2026
pfferrari
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to commercelayer/issues-app#25
What I did
useTrackingDetailsis now a standalone component, before it was used only internally inResourceShipmentParcel.It's also rendered within a Modal (it was an Overlay).
How to test
Checklist