This repository was archived by the owner on Sep 24, 2024. It is now read-only.
Differentiate list page messages in case of no results#5
Merged
Conversation
pfferrari
changed the title
pfferrari
changed the title
pfferrari
changed the title
list page messages in case of no results
gciotola
previously approved these changes
Aug 31, 2023
gciotola
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I introduced
scopeprop inListEmptyStatecomponent to let the list to have different behaviors in showing theno-items-foundmessage depending on current scope.Checklist