#186: create separate Assertor for sync statistic#221
Merged
heshamMassoud merged 9 commits into186-improve-assertionsfrom Dec 22, 2017
Merged
Conversation
andrii-kovalenko-ct
requested review from
butenkor,
heshamMassoud and
lojzatran
…ic-assertion-class
heshamMassoud
approved these changes
Dec 22, 2017
Contributor
heshamMassoud
left a comment
heshamMassoud
left a comment
There was a problem hiding this comment.
Thanks for the suggestion! :) I refactored a bit of naming of package, classes and methods as discussed.
Also added annotations and Javadocs.
Contributor
Author
|
👍 |
heshamMassoud
deleted the
186-dedicated-sync-statistic-assertion-class
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i've re-factored sync statistic assertion to use common AssertJ approach:
AbstractSyncStatisticAssertimplements common (base) sync statistic logic (seehasValues()CategorySyncStatisticAssertandProductSyncStatisticare descenders.ProductSyncStatisticdoes not add new logic, butCategorySyncStatisticAssert#hasValues()is overloaded to support category sync specific values.assertThatStatistic()methods which correspond to common AssertJ assertion pattern.Pls, note: the PR will be merged to
186-improve-assertions