300 type sync review by heshamMassoud · Pull Request #349 · commercetools/commercetools-sync-java

heshamMassoud · 2018-12-06T17:30:47Z

Summary

Review and Pair proggraming for fixes/review on Type Sync Feature.

…rtion.

codecov-io · 2018-12-06T18:16:49Z

Codecov Report

Merging #349 into 300-refactor-type-and-product-type-together will increase coverage by 0.06%.
The diff coverage is 100%.

@@                                Coverage Diff                                @@
##             300-refactor-type-and-product-type-together     #349      +/-   ##
=================================================================================
+ Coverage                                          99.18%   99.24%   +0.06%     
+ Complexity                                          1247     1245       -2     
=================================================================================
  Files                                                112      112              
  Lines                                               3069     3059      -10     
  Branches                                             149      148       -1     
=================================================================================
- Hits                                                3044     3036       -8     
+ Misses                                                13       12       -1     
+ Partials                                              12       11       -1

Impacted Files	Coverage Δ	Complexity Δ
.../types/utils/FieldDefinitionUpdateActionUtils.java	`100% <ø> (ø)`	`10 <0> (ø)`	⬇️
...s/utils/AttributeDefinitionsUpdateActionUtils.java	`100% <ø> (ø)`	`21 <0> (ø)`	⬇️
...mmercetools/sync/producttypes/ProductTypeSync.java	`100% <ø> (ø)`	`33 <0> (ø)`	⬇️
...c/types/utils/PlainEnumValueUpdateActionUtils.java	`100% <ø> (ø)`	`1 <0> (ø)`	⬇️
...cttypes/utils/PlainEnumValueUpdateActionUtils.java	`100% <ø> (ø)`	`4 <0> (ø)`	⬇️
...es/utils/AttributeDefinitionUpdateActionUtils.java	`100% <ø> (ø)`	`18 <0> (ø)`	⬇️
...pes/utils/LocalizedEnumValueUpdateActionUtils.java	`100% <ø> (ø)`	`1 <0> (ø)`	⬇️
...mercetools/sync/services/impl/TypeServiceImpl.java	`100% <100%> (+5%)`	`18 <4> (-1)`	⬇️
...in/java/com/commercetools/sync/types/TypeSync.java	`100% <100%> (ø)`	`33 <2> (ø)`	⬇️
.../commercetools/sync/types/utils/TypeSyncUtils.java	`100% <100%> (ø)`	`1 <1> (ø)`	⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff6d6f7...edf0981. Read the comment docs.

heshamMassoud added 30 commits December 5, 2018 22:13

#300: Remove empty space.

25f9a5f

#300: Statically import assertion utils.

76e4473

#300: Remove release notes for non exposed methods.

ddf7e89

#300: Reword release note entries.

291c5dc

#300: Fix bug in calculating diff of avg in benchmarks.

c87687b

#300: Delete types only from target.

1dd8d7e

#300: Making unneeded public fields private.

d29bfcd

#300: Adjust line spacing.

c13e21a

#300: Use simpler name update.

903c0ca

#300: Fix Javadoc.

7efd69d

#300: Fix line spacing.

9fdb665

#300: Fix Javadoc.

f7f8cc1

#300: Remove braces for 1-liner.

9d66f49

#300: Use optional assertion.

1154d69

#300: Remove unneeded variable reassignment.

32d00af

#300: Move method and remove key check since it's required by CTP.

7fe0b60

#300: Remove unneeded variable and format method sig.

28ed07a

#300: Fix method names.

94e9019

#300: Statically import, improve indentation and remove unneeded asse…

f5895cd

…rtion.

#300: Fix typos.

98c7b50

#300: Remove redundant supressions.

f5da17e

#300: Add @nonnull annotation.

7d77067

#300: Statically import util.

694042f

#300: Remove excessive line spacing.

9057af9

#300: Refactor TypeSyncUtils.

a08da1f

#300: Refactor util name.

f9d086f

#300: Fix Javadoc.

cfc1582

#300: Fix indentation.

577a850

#300: Fix Javadoc.

fd5cff6

#300: Add note about FieldType and AttributeType changes.

85dab40

heshamMassoud and others added 23 commits December 6, 2018 12:17

#300: Add a test case for a new draft with different order.

bd01fdb

#300: Remove unneeded asserts.

2128a66

#300: Add a unit test with a definition with a null name.

658a005

#300: Fix unit test names.

d3f8dd8

#300: Add unit test for fieldDefinition with null FieldType.

db1835e

#300: Unexpose enum differs.

dcb95f4

#300: Fix Javadocs.

b5bfa67

#300: Add more readable line spacing.

bbaab01

#300: Move tests to accessible package.

a87995d

#300: Unexpose generic enum differ.

5bbf06d

#300: Remove redundant empty check.

2459b38

#300: Replace singleton lists with optionals.

f6e34d2

#300: Change test names.

4ab3f1d

#300: Fix unit tests.

f84764f

#300: Use query builder.

a4ecf2d

#300: Fix Javadocs.

0c1e47f

#300: Change fixtures class name, package and contents.

24dca2c

#300: Avoid star import for FieldDefinitionFixtures.

7f6912c

#300: Add unit tests for mixed cases.

9c96839

#300: Move fixtures into fixtures class.

b7d4e54

#300: Remove unneeded field definitions from test.

767825f

#300: Reword notes.

98abc39

#300 fix checksStyles

7d20528

ahmetoz approved these changes Dec 6, 2018

View reviewed changes

#300: Fix Checkstyle issues.

edf0981

heshamMassoud merged commit 5377ce7 into 300-refactor-type-and-product-type-together Dec 6, 2018

heshamMassoud deleted the 300-type-sync-review branch December 6, 2018 18:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

300 type sync review#349

300 type sync review#349
heshamMassoud merged 54 commits into300-refactor-type-and-product-type-togetherfrom
300-type-sync-review

heshamMassoud commented Dec 6, 2018

Uh oh!

codecov-io commented Dec 6, 2018 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

heshamMassoud commented Dec 6, 2018

Summary

Uh oh!

codecov-io commented Dec 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov-io commented Dec 6, 2018 •

edited

Loading