Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
=========================================
Coverage 99.24% 99.24%
Complexity 1245 1245
=========================================
Files 112 112
Lines 3059 3059
Branches 148 148
=========================================
Hits 3036 3036
Misses 12 12
Partials 11 11Continue to review full report at Codecov.
|
butenkor
approved these changes
Dec 7, 2018
| 5. Add a summary of the release that is not too detailed or technical. | ||
|
|
||
| 5. Depending on the contents of the release use the subtitles below to | ||
| 6. Depending on the contents of the release use the subtitles below to |
| - **ProductType Sync** - Renamed `LocalizedEnumUpdateActionsUtils` to `LocalizedEnumUpdateActionUtils`. [#302](https://github.com/commercetools/commercetools-sync-java/issues/302) | ||
| - **ProductType Sync** - Renamed `PlainEnumUpdateActionsUtils` to `PlainEnumUpdateActionUtils`. [#302](https://github.com/commercetools/commercetools-sync-java/issues/302) | ||
| - **ProductType Sync** - `EnumsUpdateActionUtils` is now `EnumValuesUpdateActionUtils` and is meant to be **only used internally** by the library. | ||
| Its behaviour is not guaranteed if used externally. [#300](https://github.com/commercetools/commercetools-sync-java/issues/300) |
Member
There was a problem hiding this comment.
If it should be use internally only why not change class scope instead?
Contributor
Author
There was a problem hiding this comment.
@butenkor because it's used by two different packages types and productTypes, so it has to be public .
| - **ProductType Sync** - Renamed `LocalizedEnumUpdateActionsUtils` to `LocalizedEnumUpdateActionUtils`. [#302](https://github.com/commercetools/commercetools-sync-java/issues/302) | ||
| - **ProductType Sync** - Renamed `PlainEnumUpdateActionsUtils` to `PlainEnumUpdateActionUtils`. [#302](https://github.com/commercetools/commercetools-sync-java/issues/302) | ||
| - **ProductType Sync** - `EnumsUpdateActionUtils` is now `EnumValuesUpdateActionUtils` and is meant to be **only used internally** by the library. | ||
| Its behaviour is not guaranteed if used externally. [#300](https://github.com/commercetools/commercetools-sync-java/issues/300) |
Contributor
Author
There was a problem hiding this comment.
yes, because this refactoring happened in the type pr. So the commit should be linked in this issue.
ahmetoz
approved these changes
Dec 7, 2018
Contributor
ahmetoz
left a comment
ahmetoz
left a comment
There was a problem hiding this comment.
🎉 🎉 for 1.0.0, bye bye to beta 👌
lojzatran
approved these changes
Dec 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary