Prepare 1.3.0#412
Merged
heshamMassoud merged 26 commits intomasterfrom Jul 3, 2019
Merged
Conversation
…ilder at line 33 instead of defining a new one.
…ions #379 add cart discount sync options and builder with unit tests
…thub.com/commercetools/commercetools-sync-java into 379-cart-discount-feature
* #379 add cart discount update action utils and unit tests * #379 add CartDiscountService and CartDiscountSync * #379 add Integration tests for CartDiscountSync * #379 Add CartDiscount Sync Benchmarks. * #379 add Integration tests for CartDiscountService * #379 use cart discount keys instead of eng name
# Conflicts: # docs/RELEASE_NOTES.md # docs/usage/CART_DISCOUNT_SYNC.md # src/integration-test/java/com/commercetools/sync/integration/commons/utils/CartDiscountITUtils.java # src/integration-test/java/com/commercetools/sync/integration/ctpprojectsource/cartdiscounts/CartDiscountSyncIT.java # src/integration-test/java/com/commercetools/sync/integration/externalsource/cartdiscounts/CartDiscountSyncIT.java # src/main/java/com/commercetools/sync/cartdiscounts/CartDiscountSync.java # src/test/java/com/commercetools/sync/cartdiscounts/CartDiscountSyncTest.java # src/test/java/com/commercetools/sync/cartdiscounts/utils/CartDiscountUpdateActionUtilsTest.java
lojzatran
reviewed
Jul 3, 2019
|
|
||
| # Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. | ||
| DEFAULT_JVM_OPTS='"-Xmx64m"' | ||
| DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' |
Contributor
There was a problem hiding this comment.
What happened that you added this option?
Contributor
Author
There was a problem hiding this comment.
I didn't add it. It was generated with the new updated gradle wrapper.
lojzatran
approved these changes
Jul 3, 2019
Contributor
|
LGBT 🍾 |
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
=========================================
Coverage 99.31% 99.31%
Complexity 1381 1381
=========================================
Files 121 121
Lines 3379 3379
Branches 168 168
=========================================
Hits 3356 3356
Misses 12 12
Partials 11 11Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary