366: validate asset keys#509
Merged
ahalberkamp merged 20 commits intomasterfrom Apr 22, 2020
Merged
Conversation
JudeNiroshan
suggested changes
Apr 20, 2020
…eActionUtils.java Co-Authored-By: Jude Niroshan <jude.niroshan11@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
=========================================
Coverage 98.78% 98.78%
- Complexity 1502 1509 +7
=========================================
Files 134 134
Lines 3780 3795 +15
Branches 200 203 +3
=========================================
+ Hits 3734 3749 +15
Misses 31 31
Partials 15 15
Continue to review full report at Codecov.
|
…updateactionutils/BuildAssetsUpdateActionsTest.java Co-Authored-By: Jude Niroshan <jude.niroshan11@gmail.com>
…updateactionutils/BuildAssetsUpdateActionsTest.java Co-Authored-By: Jude Niroshan <jude.niroshan11@gmail.com>
ahmetoz
suggested changes
Apr 21, 2020
…eActionUtils.java Co-Authored-By: Ahmet Öz <bilmuhahmet@gmail.com>
…eActionUtils.java Co-Authored-By: Ahmet Öz <bilmuhahmet@gmail.com>
Contributor
Author
|
I have allready write some integration test, see: https://github.com/commercetools/commercetools-sync-java/pull/509/files#diff-cadc851f237ef9842d0224c27748bf3aR120 and I fixed the build @ahmetoz |
ahmetoz
approved these changes
Apr 21, 2020
JudeNiroshan
approved these changes
Apr 21, 2020
Member
|
@ahalberkamp Does it call warning callback and skip processing faulty resource or it will make a request to the API with assets without keys? |
Contributor
Author
|
@butenkor assets without keys will be skipped, so no invalid request will be sent to the API. |
Member
|
Ok, Thanks. What about sync statistics? Will the totals (updated, processed, failed, skipped...) be updated accordingly? |
Contributor
Author
|
No, because if a assetkey is missing, the given Product will still be updated and only a Warning, that the asset is not synced, will be printed out. So there is no need to change the statistic in this case. |
Member
|
ok. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In This pr, it is validated that assetKeys exists on old and new resources exist.If not a warning-callback is triggered
Fixes: #366