Conversation
…mmercetools-sync-java into 231-category-identifier
…ommons/utils/CategoryITUtils.java
…mmercetools-sync-java into 231-category-identifier
…d-support-for-key-value-document-refs # Conflicts: # src/main/java/com/commercetools/sync/products/ProductSync.java # src/test/java/com/commercetools/sync/customobjects/helpers/CustomObjectCompositeIdentifierTest.java # src/test/java/com/commercetools/sync/services/impl/CustomObjectServiceImplTest.java
- CustomObjectCompositeIdentifier should be valid before passing to service - add cacheKeysToIds method to service - refactor duplicated lines and make the methods clean as possible.
JudeNiroshan
approved these changes
Sep 25, 2020
| } | ||
|
|
||
| @Test | ||
| void sync_withNonExistingNestedCustomObjectReferenceAsAttribute_ShouldFailCreatingTheProduct() { |
Contributor
There was a problem hiding this comment.
So it means, we expect in project-sync, we execute CustomObjectSyncer before we execute ProductSyncer?
Contributor
Author
There was a problem hiding this comment.
yes, I haven't' check the custom object part on the project sync, I assume @lojzatran is considering it.
Contributor
There was a problem hiding this comment.
I do it like that in the project-sync (custom object before product), but this actually should not matter as they're not referenced to each other.
…-value-document-refs # Conflicts: # docs/RELEASE_NOTES.md # src/main/java/com/commercetools/sync/products/ProductSync.java # src/main/java/com/commercetools/sync/products/helpers/ProductBatchValidator.java # src/main/java/com/commercetools/sync/products/helpers/ProductReferenceResolver.java # src/test/java/com/commercetools/sync/products/helpers/ProductBatchValidatorTest.java
…atchValidatorTest.java Co-authored-by: Jude Niroshan <jude.niroshan11@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#564
Todo