#235 Add BatchValidator for category sync#568
Closed
salander85 wants to merge 21 commits intomasterfrom
Closed
Conversation
Changes in CategoryBatchProcessor * Rename to CategoryBatchValidator * Handle errors inside * Return a ImmutablePair of valid drafts and valid keys from the validation method * Pass the batch of categoryDrafts in the validation method * Change constructor to init syncOptions and statistics fields
…y-ref' into #235_improve-caching-for-category-ref
…y-ref' into #235_improve-caching-for-category-ref # Conflicts: # src/main/java/com/commercetools/sync/categories/CategorySync.java # src/main/java/com/commercetools/sync/categories/helpers/CategoryBatchValidator.java
…y-ref' into #235_improve-caching-for-category-ref # Conflicts: # src/main/java/com/commercetools/sync/services/impl/CategoryServiceImpl.java # src/test/java/com/commercetools/sync/categories/CategorySyncTest.java
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
============================================
- Coverage 99.20% 99.14% -0.06%
- Complexity 1871 1881 +10
============================================
Files 157 158 +1
Lines 4657 4691 +34
Branches 280 285 +5
============================================
+ Hits 4620 4651 +31
- Misses 19 22 +3
Partials 18 18
Continue to review full report at Codecov.
|
…y-ref' into #235_improve-caching-for-category-ref
salander85
changed the title
ahmetoz
reviewed
Sep 16, 2020
ahmetoz
approved these changes
Sep 16, 2020
Contributor
|
Will be covered by #574 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement a CategoryBatchValidator to improve caching in category sync
Relevant Issues
#235
Todo
Hints for Review
NOTE: CodeCov is failing because exception handling is never reached. As we need to come up with a new solution in the ReferenceResolvers this is ignored for now. Fixing this issue should be part of the second part of the ticket which is generalization of the Validator.