Open
Conversation
room is tombstoned.
Airyzz
requested changes
Mar 3, 2026
Contributor
Airyzz
left a comment
Airyzz
left a comment
There was a problem hiding this comment.
Thank you for this! Looks really good, just a few small tweaks please!
commet/lib/client/matrix/timeline_events/matrix_timeline_event_room_tombstone.dart
Outdated
Show resolved
Hide resolved
Airyzz
reviewed
Mar 3, 2026
Airyzz
reviewed
Mar 3, 2026
Author
Thank you for the feedback :) Sure, will push additional changes! |
room. - Only pass room id for getRoom and getRoomByAlias - Pass address including via param for joinRoom
Author
|
@Airyzz ok, I have pushed additional changes. please have a look :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, Thanks for this cool matrix client :)
I got many tombstoned room (mostly due to room upgrades on other homeserver) and wanted feature for #482
So I have added some features for that. This PR includes 2 parts of changes.
Room tombstoned timeline event
This handles room tombstoned timeline event(
m.room.tombstone) then show message "This room has been replaced" in chat timeline.commet/lib/client/matrix/timeline_events/matrix_timeline_event_room_tombstone.dartandcommet/lib/client/timeline_events/timeline_event_room_tombstone.dartcommet/lib/client/matrix/matrix_room.dart(Line 549-550, 738, 739)commet/lib/ui/molecules/timeline_events/timeline_view_entry.dartRoom tombstoned message and Enter new room button on chat input area
This uses room's state to check if the room has been tombstoned, then show "This room has been replaced" message on chat input area along with a button "Enter new room". Clicking the button resolves and opens the new replacement room then if that worked, it make current user to leave the tombstoned room.
commet/lib/client/matrix/matrix_room.dartLine 980-111: handles room tombstoned state of the matrix room. For resolving if the room has been tombstoned and has info for new replacement room.commet/lib/client/matrix_background/matrix_background_room.dartfor also handling room tombstoned events of rooms in background.commet/lib/client/room.dartfor storing room tombstoned state.commet/lib/ui/organisms/chat/chat_view.darttombstoneRoomReplacedMessageRoom tombstoned message for showing on chat input areatombstoneEnterNewRoomButton label text for "Enter new room" buttonopenReplacementRoomAndLeaveThis handles entering new replacement room then leaving the tombstoned room.Disclosure: I'd like to inform that I did got many help from Generative AI coding tool (OpenCode, with gpt-5.3-codex model) for understanding the codebase and working with this changes. (Sorry, I have noted about the guideline a bit late) As I do have overall understadings of changes i have made, if there is any fixes required for this PR, feel free to let me know.
Test demo
2026-02-25.01-10-12.mp4