Skip to content

feat: output security group id from the database module #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmonkman merged 1 commit into from
Jun 13, 2022
Merged

feat: output security group id from the database module #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/database/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,6 @@ Create an RDS database.
|------|-------------|
| database\_endpoint | The internal hostname used to connect to the database |
| database\_id | The instance id of the database |
| database\_security\_group\_id | The id of the created security group |

<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
6 changes: 3 additions & 3 deletions modules/database/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ locals {

module "rds_security_group" {
source = "terraform-aws-modules/security-group/aws"
version = "3.18.0"
version = "4.9.0"

name = "${var.project}-${var.additional_identifier}${var.environment}-rds-sg"
description = "Security group for RDS DB"
Expand Down Expand Up @@ -70,7 +70,7 @@ module "rds_postgres" {

port = "5432"

vpc_security_group_ids = [module.rds_security_group.this_security_group_id]
vpc_security_group_ids = [module.rds_security_group.security_group_id]

maintenance_window = "Mon:00:00-Mon:03:00"
backup_window = "03:00-06:00"
Expand Down Expand Up @@ -129,7 +129,7 @@ module "rds_mysql" {

port = "3306"

vpc_security_group_ids = [module.rds_security_group.this_security_group_id]
vpc_security_group_ids = [module.rds_security_group.security_group_id]

maintenance_window = "Mon:00:00-Mon:03:00"
backup_window = "03:00-06:00"
Expand Down
5 changes: 5 additions & 0 deletions modules/database/outputs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,8 @@ output "database_id" {
description = "The instance id of the database"
value = (var.database_engine == "postgres") ? module.rds_postgres[0].db_instance_id : module.rds_mysql[0].db_instance_id
}

output "database_security_group_id" {
description = "The id of the created security group"
value = module.rds_security_group.security_group_id
}