Skip to content

Mode auth implementation into a module#182

Merged
davidcheung merged 13 commits intomainfrom
auth-module
Mar 5, 2021
Merged

Mode auth implementation into a module#182
davidcheung merged 13 commits intomainfrom
auth-module

Conversation

@davidcheung
Copy link
Copy Markdown
Contributor

this enables someone to spin up extra auth instances and steps towards decoupling the infra / application logic more

@davidcheung davidcheung requested a review from a team as a code owner February 24, 2021 19:31
Comment thread templates/kubernetes/terraform/environments/prod/main.tf Outdated
Comment thread templates/kubernetes/terraform/modules/kubernetes/user_auth.tf Outdated
@bmonkman
Copy link
Copy Markdown
Contributor

Looks like the zero create check failed. And when you figure out why we should see if we can add a guard around that case to give a better error message than a nil ptr dereference.

@davidcheung
Copy link
Copy Markdown
Contributor Author

Yeah I wrote a zero of terraform-aws-zero that is not yet released yet, i wonder if thats the problem
not sure why it would fail at zero create, will dig deeper

Comment thread templates/kubernetes/terraform/environments/stage/main.tf Outdated
@davidcheung davidcheung merged commit fc203b3 into main Mar 5, 2021
@davidcheung davidcheung deleted the auth-module branch March 5, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants