many fixes#187
Merged
davidcheung merged 9 commits intomainfrom Mar 17, 2021
Merged
Conversation
Contributor
davidcheung
commented
Mar 16, 2021
davidcheung
commented
- removing empty deployment from db creation
- fix reference to undeclared variables
- allow notification secrets to partially exist
- fix user-auth domain name ended up with extra dot
- fix user-auth db-endpoint failure due to ext-svc
we could move this back to deployable backend if we see the need this causes an error while spinning up user-auth db because project namespace is not created
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.