default subdomain values for zero-module.yml #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmonkman
reviewed
Jun 10, 2020
| - field: productionFrontendSubdomain | ||
| label: Production Frontend Host Name (e.g. app.) | ||
| default: app. | ||
| - field: productionBackendSubdomain |
Contributor
There was a problem hiding this comment.
If we don't use these backend domains we should probably remove them.
Contributor
Author
There was a problem hiding this comment.
this would make the prompt order more confusing though, it would
loads then prompts eks stack
productionHostRoot
productionFrontendSubdomain
stagingHostRoot
stagingFrontendSubdomain
loads then prompts deployable backend
productionBackendSubdomain
stagingBackendSubdomain
Contributor
There was a problem hiding this comment.
Yeah, that's annoying, though we'll have to deal with it eventually.. You can leave it for now I guess.
bmonkman
approved these changes
Jun 10, 2020
bmonkman
pushed a commit
that referenced
this pull request
Oct 10, 2020
default subdomain values for zero-module.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.