-
Notifications
You must be signed in to change notification settings - Fork 9
rds: db monitoring role to be created by TF #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
terraform/modules/database/main.tf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ARN is not required when the previous two parameters are supplied. It will create a role and then use that ARN.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought so too, it actually errors out when you don't provide it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What sort of error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InvalidParameterCombination: A MonitoringRoleARN value is required if you specify a MonitoringInterval value other than 0.
Feels like some parameter validation enforcement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like its supposed to be fixed in https://github.com/terraform-aws-modules/terraform-aws-rds/releases/tag/v2.12.0
we're using 2.4.0, maybe going to ^2.12.0 will solve this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah let's bump that version up!
39e73a9 to
8433cb7
Compare
bmonkman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
RDS creation does not guarentee the enhance_monitoring role is created before TF tries to use the role, creating it will stop it from erroring
8433cb7 to
bb80f5e
Compare
rds: db monitoring role to be created by TF
RDS creation does not guarentee the enhance_monitoring role is created
before TF tries to use the role, creating it will stop it from erroring