Skip to content

Conversation

@davidcheung
Copy link
Contributor

RDS creation does not guarentee the enhance_monitoring role is created
before TF tries to use the role, creating it will stop it from erroring

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ARN is not required when the previous two parameters are supplied. It will create a role and then use that ARN.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so too, it actually errors out when you don't provide it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What sort of error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InvalidParameterCombination: A MonitoringRoleARN value is required if you specify a MonitoringInterval value other than 0.

Feels like some parameter validation enforcement.

Copy link
Contributor Author

@davidcheung davidcheung Apr 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like its supposed to be fixed in https://github.com/terraform-aws-modules/terraform-aws-rds/releases/tag/v2.12.0

we're using 2.4.0, maybe going to ^2.12.0 will solve this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah let's bump that version up!

@davidcheung davidcheung force-pushed the rds-monitoring-role branch from 39e73a9 to 8433cb7 Compare April 16, 2020 18:00
Copy link
Contributor

@bmonkman bmonkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

RDS creation does not guarentee the enhance_monitoring role is created
before TF tries to use the role, creating it will stop it from erroring
@davidcheung davidcheung force-pushed the rds-monitoring-role branch from 8433cb7 to bb80f5e Compare April 16, 2020 21:35
@davidcheung davidcheung merged commit 6ebc8a4 into master Apr 16, 2020
@davidcheung davidcheung deleted the rds-monitoring-role branch April 16, 2020 21:36
bmonkman pushed a commit that referenced this pull request Oct 10, 2020
rds: db monitoring role to be created by TF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants