A bunch of small fixes to get the pipeline running#5
Conversation
| fieldRef: | ||
| fieldPath: metadata.name | ||
| - name: SERVER_PORT | ||
| value: "80" |
There was a problem hiding this comment.
just curious why do we put backend on 80? would it make it more confusing what is being mapped to what? (eg hides the ingress mapping and stuff)
There was a problem hiding this comment.
Because it's serving HTTP traffic, and that is the default port. Since you don't need to deal with ports conflicting in Kubernetes this isn't a problem.
What do you mean about hiding the ingress mapping?
There was a problem hiding this comment.
as in boilerplate backend port: 80 may lead people to think the port in the deployment is the port for the end url (which in this case it is)
Kinda hides the fact that ingress will expose it at 80 regardless
There was a problem hiding this comment.
If someone fundamentally doesn't understand the difference between deployment, service, and ingress, we should try to solve that with documentation, not hoping that they get confused by all the different ports and look it up.
There was a problem hiding this comment.
Also we are giving them a nice name to refer to, though I realize I put it in the wrong spot above. Will fix that.
2 participants
No description provided.