default disable ci cache & conditional cf-keypairs#6
Merged
davidcheung merged 2 commits intomainfrom Oct 13, 2020
Merged
Conversation
- package lock is actually required for circleCI to cache, it throws without the key, see https://circleci.com/developer/orbs/orb/circleci/node#commands-install-package - so now it will just npm install instead of trying to restore cache, left commented block for user to switch to instead - since CF keypairs are now optionally generated, the injection should also be optionally done
bmonkman
approved these changes
Oct 13, 2020
davidcheung
commented
Oct 13, 2020
templates/.circleci/config.yml
Outdated
| - node/install-packages: | ||
| cache-path: "./node_modules" | ||
| app-dir: . | ||
| ## This `npm i --package-lock` step is used so boilerplate can pick up latest version before locking |
Contributor
Author
There was a problem hiding this comment.
the package-lock.json changes includes all the dependencies each driver would have
the different between mysql vs postgres is 200 line differences so it wouldnt really make sense to template
another way is we ship both drivers, which i think is worse? since it will be on their production if user dont go and fix it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without the key, see https://circleci.com/developer/orbs/orb/circleci/node#commands-install-package
left commented block for user to switch to instead
also be optionally done