Skip to content

Conversation

@suecharo
Copy link
Contributor

I think it's a very good project.
I'll try to use it in more detail after this.
I'll send you a pull request for what's interesting in the docs first.

The fixes are as follows:

  • Fix some indents in the example code.

e.g.

with open(input_filename) as f:
  csv_reader = csv.reader(f)
  • Specify type annotation with a class instead of a string in the class name.
    • I apologize if you use this notation as an expected behavior.

e.g.

>>> dataset2: 'CWLFilePathInput' = './data/data.csv'
  • Fix a mistake in the class specification for type annotation

e.g.

>>> dataset1: CWLBooleanInput = 1
>>> dataset2: 'CWLBooleanInput' = 2

@giannisdoukas
Copy link
Contributor

Hi! Thank you very much for contacting.

Actually what you changed is not wrong but maybe it is not very clear in the documentation. You can use the typing annotation for the basic data types by importing the ipython2cwl or if you don't want to import them you can just write the typing annotation as a string. For example, if you check here at cell 4 all these annotations are correct.

@suecharo
Copy link
Contributor Author

You can use the typing annotation for the basic data types by importing the ipython2cwl or if you don't want to import them you can just write the typing annotation as a string. For example, if you check here at cell 4 all these annotations are correct.

Great!!
I think it's a very good specification.
I'll push the fix commit again.

@giannisdoukas giannisdoukas merged commit 1122777 into common-workflow-lab:master Jul 16, 2020
@giannisdoukas
Copy link
Contributor

@suecharo Thank you very much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants