Skip to content

Bump org.testcontainers:junit-jupiter from 1.19.3 to 1.19.4 #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Bump org.testcontainers:junit-jupiter from 1.19.3 to 1.19.4 #602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9573d36
Bump org.testcontainers:junit-jupiter from 1.19.3 to 1.19.4
dependabot[bot] Jan 26, 2024
1cda2ee
Allow system packages to be upgraded in CI
kinow Jan 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,10 @@ RUN apk add --update \
heimdal \
&& rm -rf /var/cache/apk/*

#wheel needed by ruamel.yaml for some reason
RUN pip3 install -U wheel setuptools pip
RUN pip3 install cwltool
# wheel needed by ruamel.yaml for some reason
# https://stackoverflow.com/a/75722775
RUN pip3 install --break-system-packages -U wheel setuptools pip
RUN pip3 install --break-system-packages cwltool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use pipx instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that too, but then we will have to modify another step above to install it, with sudo apt install pipx I think. Or use another docker multi-stage build image to get python with some virtual env (mamba/pip/etc). Maybe we can create an issue to check which option would work best.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding pipx to the apt-get install will work easily


RUN cwltool --version

Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>junit-jupiter</artifactId>
<version>1.19.3</version>
<version>1.19.4</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down