Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 26, 2024

Bumps org.testcontainers:junit-jupiter from 1.19.3 to 1.19.4.

Release notes

Sourced from org.testcontainers:junit-jupiter's releases.

1.19.4

What's Changed

🚀 Features & Enhancements

☠️ Deprecations

  • Deprecate support for docker.elastic.co/elasticsearch/elasticsearch-oss (#4574) @​dadoonet

🐛 Bug Fixes

📖 Documentation

🧹 Housekeeping

📦 Dependency updates

... (truncated)

Commits
  • dc0e3da Merge pull request #8162 from testcontainers/combined-pr-branch
  • 733508f Merge remote-tracking branch 'origin/dependabot/gradle/modules/influxdb/org.i...
  • c0610e3 Merge remote-tracking branch 'origin/dependabot/gradle/modules/solace/com.sol...
  • 39641d3 Bump org.influxdb:influxdb-java from 2.23 to 2.24 in /modules/influxdb
  • 47400be Bump com.solacesystems:sol-jcsmp in /modules/solace
  • f9116b1 Bump com.google.guava:guava from 32.1.3-jre to 33.0.0-jre in /core
  • 490f8f8 Update activemq-client version to 6.0.1 (#8150)
  • 489ac7d Merge pull request #8161 from testcontainers/combined-pr-branch
  • 2d37a36 New Solace certificates for integration test (#8160)
  • 9fa2241 Merge remote-tracking branch 'origin/dependabot/gradle/modules/pulsar/org.apa...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [org.testcontainers:junit-jupiter](https://github.com/testcontainers/testcontainers-java) from 1.19.3 to 1.19.4.
- [Release notes](https://github.com/testcontainers/testcontainers-java/releases)
- [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md)
- [Commits](testcontainers/testcontainers-java@1.19.3...1.19.4)

---
updated-dependencies:
- dependency-name: org.testcontainers:junit-jupiter
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jan 26, 2024
@kinow kinow force-pushed the dependabot/maven/org.testcontainers-junit-jupiter-1.19.4 branch from 37816d5 to 1cda2ee Compare January 27, 2024 10:31
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add the change to pip install, as the image is a Java and Maven image. And we are installing Python in Linux. Newer versions of Python seem to complain when you are about to break system Python (which is good!). But we can assume that's safe as we are doing that in a container and in an isolated env.

@kinow kinow requested a review from mr-c January 27, 2024 10:40
# wheel needed by ruamel.yaml for some reason
# https://stackoverflow.com/a/75722775
RUN pip3 install --break-system-packages -U wheel setuptools pip
RUN pip3 install --break-system-packages cwltool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use pipx instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do that too, but then we will have to modify another step above to install it, with sudo apt install pipx I think. Or use another docker multi-stage build image to get python with some virtual env (mamba/pip/etc). Maybe we can create an issue to check which option would work best.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding pipx to the apt-get install will work easily

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 9, 2024

A newer version of org.testcontainers:junit-jupiter exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@mr-c
Copy link
Member

mr-c commented Feb 18, 2024

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 18, 2024

Superseded by #605.

@dependabot dependabot bot closed this Feb 18, 2024
@dependabot dependabot bot deleted the dependabot/maven/org.testcontainers-junit-jupiter-1.19.4 branch February 18, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants