Skip to content

add social icons to nav menu across both viewports#87

Merged
freemvmt merged 3 commits intomainfrom
dg/minor-issues-comments
Apr 21, 2026
Merged

add social icons to nav menu across both viewports#87
freemvmt merged 3 commits intomainfrom
dg/minor-issues-comments

Conversation

@freemvmt
Copy link
Copy Markdown
Collaborator

Description

An addendum to #86 to surface socials on mobile and desktop views in the top navigation, as per discussion on the ticket here.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I've checked the spec (e.g. Figma file) and documented any divergences.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I've updated the documentation accordingly.
  • Replace unused checkboxes with bullet points.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds social media icon links back into the top navigation for both desktop and mobile viewports (as a follow-up to #86), while also correcting Bootstrap Icons class usage so icons render reliably.

Changes:

  • Add social icon links to the desktop header area (md+).
  • Add social icon links to the collapsed mobile navigation menu.
  • Fix Bootstrap Icons class prefixes for the search icon and footer social icons (bi bi-*).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread stopwatch/templates/base.html Outdated
Comment thread stopwatch/templates/base.html Outdated
Comment thread stopwatch/templates/base.html Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@joaquimds joaquimds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Copilot's comments are negligible imo

@freemvmt
Copy link
Copy Markdown
Collaborator Author

Approved. Copilot's comments are negligible imo

Thanks @joaquimds! I did take the advice and extract the socials as a template. I also buffed out the readme a bit with some of my notes from setup, in case useful for the next dev who lands here!

@freemvmt freemvmt merged commit 675fa77 into main Apr 21, 2026
@freemvmt freemvmt deleted the dg/minor-issues-comments branch April 21, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants