fix bugs in Python test scripts#815
Merged
jgm merged 2 commits intocommonmark:masterfrom Dec 20, 2025
Merged
Conversation
urllib.quote and urllib.unquote were moved to urllib.parse in Python 3.
cmark_markdown_to_html takes 3 arguments (text, len, options) but argtypes only defined 2. Added c_int for the options parameter.
Member
|
thanks for this! |
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two bugs in the test infrastructure:
normalize.py -
urllib.quoteandurllib.unquotewere moved tourllib.parsein Python 3 and no longer exist in theurllibmodule. This causes anAttributeErrorwhen the code path is triggered.cmark.py - The C function
cmark_markdown_to_html(text, len, options)takes 3 arguments, butargtypesonly defined 2. Addedc_intfor the options parameter.Thanks for maintaining CommonMark!