Handle the array push issue #1519
Conversation
| // We may have linked docs that storage doesn't know about | ||
| const storageProvider = this._getStorageProviderForSpace(doc.space); | ||
| const { missing } = this._queryLocal(doc.space, uri, storageProvider); | ||
| const { missing, loaded } = this._queryLocal( |
There was a problem hiding this comment.
By doing the queryLocal here, before the await runtime.idle in sendDocValue, it's possible that the set of linked documents could change between this check and the value capture in sendDocValue, meaning that we may link to different docs by the time we're in there.
This PR is mostly a stopgap, though, since a transaction should contain better information about linked docs.
As mentioned below, there's also an issue with the timing of pulling cells we are linked to, but don't already have.
This can happen if you change the schema of a cell to include docs that were previously excluded. It can also occur if you have a well known cause that you used to create a cell (so you have a local unsynced copy and there's also a copy on the server).
|
I may also add the modified array_push integration test, since it's different enough from the main test. |
Previously, when we pushed an item into an array, we would write the doc with the array, then later, write the doc with the array element.
This is problematic for another client, since they can get the updated array, and then attempt to load the array element before it has been written to the server, which means they end up treating it as an empty element.
This PR changes things to batch the write of a document to include any linked documents reachable by the schema query.
There are some problems with this code, but it makes things better.
Summary by cubic
Fixed an issue where pushing an item to an array could cause clients to see empty elements by batching document writes to include all linked documents.