fix(runner): avoid infinite recursion in function cacher

[seefeldb]

Summary by cubic

Prevents infinite recursion in the runner’s function discovery by tracking visited nodes, so cyclic recipes/modules no longer cause hangs or stack overflows.

• Bug Fixes
  • Added a shared seen Set across discovery methods to short-circuit revisits of recipes, modules, and values.
  • Propagated seen through nested recipes, module references, and input traversal.
  • Handles circular graphs without altering behavior for acyclic cases.

[Copilot]

Pull Request Overview

This PR fixes an infinite recursion issue in the function caching mechanism by adding cycle detection to the recursive traversal of recipes and modules.

• Adds seen parameter to track visited objects and prevent cycles
• Updates all recursive function discovery methods to pass and check the seen set
• Prevents infinite loops when modules or recipes contain circular references

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="packages/runner/src/runner.ts">

<violation number="1" location="packages/runner/src/runner.ts:715">
Adding value to seen before delegating causes nested modules/recipes found in inputs to be skipped; module/recipe handlers return early due to seen.has(...). Guard only non-module/recipe objects here.</violation>
</file>

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}