fix(runner): preserve metadata when rewriting legacy aliases #1803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure toJSONWithLegacyAliases no longer drops schema info while normalizing alias depths - add explanatory comments for the whole function - extend json-utils tests to cover regression scenario
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the toJSONWithLegacyAliases function where schema metadata was being dropped when rewriting legacy aliases. The fix ensures that when expanding shadow ref aliases and incrementing numeric alias cells, all metadata (including schema and rootSchema) is preserved.
- Preserve metadata when expanding shadow ref aliases by using spread operator for all alias properties except cell
- Preserve metadata when incrementing numeric alias cells by spreading the entire alias object before overriding specific properties
- Add comprehensive tests to verify schema preservation in both scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/runner/src/builder/json-utils.ts | Fix metadata preservation in toJSONWithLegacyAliases and add explanatory comments |
| packages/runner/test/json-utils.test.ts | Add test coverage for schema preservation regression scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="packages/runner/src/builder/json-utils.ts">
<violation number="1" location="packages/runner/src/builder/json-utils.ts:78">
Typo in comment: "is should" should be "it should" for clarity.</violation>
<violation number="2" location="packages/runner/src/builder/json-utils.ts:159">
Comment contradicts the code: the code returns the result when the object is empty, not undefined.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
seefeldb
deleted the
berni/ct-919-missing-tool-schema-on-recipe-instantiation-from-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Preserves schema metadata when rewriting legacy aliases in toJSONWithLegacyAliases, fixing missing tool schemas during recipe instantiation from defaults. Addresses CT-919.