Skip to content

Conversation

@ubik2
Copy link
Contributor

@ubik2 ubik2 commented Sep 23, 2025

  • These tests are causing problems in the integration test, so temporarily disable them.
  • There was also an issue where we were instantiating more runtimes than needed (since beforeAll/afterAll can register multiple hooks that will all be called). The for loop was tightened to just encapsulate the it.

Summary by cubic

Temporarily skip two flaky chatbot pattern tests and fix test setup to avoid multiple runtime instances, stabilizing the patterns integration suite.

  • Bug Fixes
    • Skip chatbot-list-view.tsx and chatbot-note-composed.tsx in the patterns integration run.
    • Move CharmsController/Identity setup to top-level beforeAll/afterAll and limit the file loop to only creating test cases, preventing duplicate runtime instantiation.

- These tests are causing problems in the integration test, so temporarily disable them.
- There was also an issue where we were instantiating more runtimes than needed (since beforeAll/afterAll can register multiple hooks that will all be called). The for loop was tightened to just encapsulate the `it`.
@ubik2 ubik2 requested a review from jsantell September 23, 2025 19:07
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@ubik2 ubik2 merged commit bd67563 into main Sep 23, 2025
8 checks passed
@ubik2 ubik2 deleted the robin/skip-chatbot-pattern-tests branch September 23, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants