Skip to content

Add PDF support via ct-file-input base component #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 2, 2025
Merged

Add PDF support via ct-file-input base component #2151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
807c31d
feat(ui): Add ct-file-input base component
jkomoros Nov 23, 2025
cb1091c
refactor(ui): Refactor ct-image-input to extend ct-file-input
jkomoros Nov 23, 2025
e32fa9f
test(ui): Add manual test file for ct-file-input and ct-image-input
jkomoros Nov 23, 2025
7bbea4c
feat(types): Add JSX types for ct-file-input component
jkomoros Nov 23, 2025
590ec14
fix: Address cubic code review issues
jkomoros Nov 23, 2025
951fdb4
fix: Address additional cubic code review issues
jkomoros Nov 24, 2025
1016203
Remove test files, screenshots, and bug reports from PR
jkomoros Nov 24, 2025
cbff650
Format and lint
bfollington Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions packages/html/src/jsx.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2864,6 +2864,7 @@ interface CTListElement extends CTHTMLElement {}
interface CTListItemElement extends CTHTMLElement {}
interface CTLoaderElement extends CTHTMLElement {}
interface CTInputElement extends CTHTMLElement {}
interface CTFileInputElement extends CTHTMLElement {}
interface CTImageInputElement extends CTHTMLElement {}
interface CTInputLegacyElement extends CTHTMLElement {}
interface CTCheckboxElement extends CTHTMLElement {}
Expand Down Expand Up @@ -3247,6 +3248,32 @@ interface CTInputLegacyAttributes<T> extends CTHTMLAttributes<T> {
"customStyle"?: string;
}

interface CTFileInputAttributes<T> extends CTHTMLAttributes<T> {
"multiple"?: boolean;
"maxFiles"?: number;
"accept"?: string;
"buttonText"?: string;
"variant"?:
| "default"
| "primary"
| "secondary"
| "outline"
| "ghost"
| "link"
| "destructive";
"size"?: "default" | "sm" | "lg" | "icon";
"showPreview"?: boolean;
"previewSize"?: "sm" | "md" | "lg";
"removable"?: boolean;
"disabled"?: boolean;
"maxSizeBytes"?: number;
"files"?: any[]; // FileData[]
"$files"?: any; // CellLike<FileData[]>
"onct-change"?: EventHandler<any>;
"onct-remove"?: EventHandler<any>;
"onct-error"?: EventHandler<any>;
}

interface CTImageInputAttributes<T> extends CTHTMLAttributes<T> {
"multiple"?: boolean;
"maxImages"?: number;
Expand Down Expand Up @@ -3811,6 +3838,10 @@ declare global {
CTInputAttributes<CTInputElement>,
CTInputElement
>;
"ct-file-input": CTDOM.DetailedHTMLProps<
CTFileInputAttributes<CTFileInputElement>,
CTFileInputElement
>;
"ct-image-input": CTDOM.DetailedHTMLProps<
CTImageInputAttributes<CTImageInputElement>,
CTImageInputElement
Expand Down
Loading