feat: Move favorite charm logic to its own view and discerns between local and remote state

[jsantell]

Summary by cubic

Moved favorite charm handling into a dedicated FavoriteButton component with optimistic local state and server sync. Simplifies the header and removes the toggle-favorite command from the command pipeline.

• New Features

  • Added x-favorite-button that toggles favorites instantly, then syncs with the server; prefers local state until sync completes.
  • Star icon with tooltip; exported via components index.

• Refactors

  • HeaderView now uses x-favorite-button and removes custom favorite listeners/state; small button-group style tweak.
  • Removed toggle-favorite command from RootView; processCommand is synchronous with try/catch.

^{Written for commit 3278376. Summary will update automatically on new commits.}

[cubic-dev-ai]

1 issue found across 5 files

Prompt for AI agents (all 1 issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/shell/src/components/FavoriteButton.ts">

<violation number="1" location="packages/shell/src/components/FavoriteButton.ts:53">
P2: Ensure the sync task runs even when the favorite mutation fails so the optimistic state doesn’t stay stuck after an error.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR}

[cubic-dev-ai]

P2: Ensure the sync task runs even when the favorite mutation fails so the optimistic state doesn’t stay stuck after an error.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At packages/shell/src/components/FavoriteButton.ts, line 53:

<comment>Ensure the sync task runs even when the favorite mutation fails so the optimistic state doesn’t stay stuck after an error.</comment>

<file context>
@@ -0,0 +1,127 @@
+      await manager.addFavorite(charmCell);
+    }
+
+    this.isFavoriteSync.run();
+  }
+
</file context>

Suggested change

	this.isFavoriteSync.run();
	}
	protected override willUpdate(changedProperties: PropertyValues): void {
	if (changedProperties.has("charmId")) {
	this.isFavorite = undefined;
	}
	}
	try {
	const charmCell = (await this.rt.cc().get(this.charmId, true)).getCell();
	if (isFavorite) {
	await manager.removeFavorite(charmCell);
	} else {
	await manager.addFavorite(charmCell);
	}
	} finally {
	this.isFavoriteSync.run();
	}

[bfollington]

Nice, definitely better to have this all bundled in one place. LGTM.