Skip to content

Conversation

@bfollington
Copy link
Contributor

@bfollington bfollington commented Dec 5, 2025

Summary by cubic

Open-ended wish({ query }) now launches suggestion.tsx to find and run a useful pattern, returning a live result cell and minimal UI. Adds example and tester patterns to validate the flow.

  • New Features

    • Generic wish calls run suggestion.tsx and return WishState<Cell>.
    • Runtime loader and shared compile cache added for suggestion.tsx.
    • New patterns: arbitrary-wish-example.tsx and suggestion-test.tsx.
    • Added omnibox wishAndNavigate tool to auto-navigate to wish results.
  • Bug Fixes

    • Fixed intermittent crash in fetchAndRunPattern by filtering undefined file entries.
    • Strengthened fetch-program cache schema to prevent undefined elements in nested arrays.

Written for commit fcd22fa. Summary will update automatically on new commits.

@bfollington
Copy link
Contributor Author

bfollington commented Dec 5, 2025

  • fetchProgram + compileAndRun + caching leads to:
installHook.js:1 TypeError: Cannot read properties of undefined (reading 'name')
    at compile-and-run.ts:184:42
    at Array.some (<anonymous>)
    at compile-and-run.ts:184:22
    at scheduler.ts:291:25
    at new Promise (<anonymous>)
    at Scheduler.run (scheduler.ts:232:27)
    at Scheduler.execute (scheduler.ts:597:20)

@bfollington bfollington force-pushed the ben/2025-12-05-freeform-wish branch from 5b98feb to f82a338 Compare December 6, 2025 01:04
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 8 files

Prompt for AI agents (all 1 issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/patterns/suggestion-test.tsx">

<violation number="1" location="packages/patterns/suggestion-test.tsx:35">
P3: Inconsistent fallback string: `&quot;waiting..&quot;` should likely be `&quot;waiting...&quot;` to match the string used on line 27.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

<h2>Note</h2>
<ct-cell-context $cell={suggestion2} label="Note Suggestion">
{derive(suggestion2, (s) => {
return s?.result ?? "waiting..";
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Inconsistent fallback string: "waiting.." should likely be "waiting..." to match the string used on line 27.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/patterns/suggestion-test.tsx, line 35:

<comment>Inconsistent fallback string: `&quot;waiting..&quot;` should likely be `&quot;waiting...&quot;` to match the string used on line 27.</comment>

<file context>
@@ -0,0 +1,43 @@
+          &lt;h2&gt;Note&lt;/h2&gt;
+          &lt;ct-cell-context $cell={suggestion2} label=&quot;Note Suggestion&quot;&gt;
+            {derive(suggestion2, (s) =&gt; {
+              return s?.result ?? &quot;waiting..&quot;;
+            })}
+          &lt;/ct-cell-context&gt;
</file context>
Suggested change
return s?.result ?? "waiting..";
return s?.result ?? "waiting...";

✅ Addressed in fcd22fa

@bfollington bfollington merged commit 93f577e into main Dec 8, 2025
1 check passed
@bfollington bfollington deleted the ben/2025-12-05-freeform-wish branch December 8, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants