Skip to content

Conversation

@jsantell
Copy link
Collaborator

@jsantell jsantell commented Dec 5, 2025

This reverts commit 6e979d0.

Still too many intermittent failures due to timing changes.


Summary by cubic

Reverts the recent pattern selection changes and restores the previous active/default charm flow to reduce intermittent timing failures. Also stabilizes integration tests with simpler, more deterministic checks.

  • Refactors

    • Restore unified pattern resolution in AppView via viewToPatterns and remove pattern caching/helpers from RuntimeInternals.
    • Rename built-in type from "space-root" to "space-default" and align PatternFactory/BodyView APIs; iframe test now reads _activePatterns.
    • Simplify CharmsController.create to return CharmController consistently.
  • Bug Fixes

    • Replace fragile wait loops with direct queries and assert-based checks across integration tests; add small sleeps where needed.
    • Make ct-list and ct-tags edits/removals reliable by dispatching clicks and waiting for DOM changes.
    • Re-enable instantiate-recipe flow and assert navigation via URL change.

Written for commit d64c507. Summary will update automatically on new commits.

…pace root pattern, syncing state (#2188)"

This reverts commit 6e979d0.
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 16 files

@jsantell jsantell merged commit 5f7f106 into main Dec 5, 2025
10 checks passed
@jsantell jsantell deleted the revert-6e979d0b0c021877882e8f3c13262073bcf36103 branch December 5, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants