Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An effort to port our shared and frontend modules to deno, and running Jumble's vite server in deno, and aligning patterns and tools across all of our active TS modules.
typescript/packages/deno.jsonand are available for use in all workspace members. Workspace members (e.g.@commontools/memory) are also available in all members, though not all packages are suitable for both deno and browser environments. Roughly, dependencies shared by multiple packages are put in the workspace, otherwise they're defined in that package's deno.json.tsconfig.json,eslintconfig,.prettier*andvite.config.js(outside of Jumble)deno.lock(memory, toolshed), now tracked in workspaceaccessorto (lit) decorators to be compatible with Deno as "Standard Decorators"vitest(node) now in deno using@std/testing/bddframework. Tests run bydeno test, ordeno task testif permissions required, TBD how to reconcile, could always implementdeno task test.typescript/packages/deno-vite-plugin) with a change to cache calls todeno info, otherwise the performance is too slow to be usable (seetypescript/packages/deno-vite-plugin/src/resolver.tsandresolverCachefor changes).--node-modules-dir=auto, adding anode_modulesdir to the workspace. Not ideal, but node is not actually used.TODO (before landing)
Follow ups (after landing)
web-test-runnerdo not yet have an alternative (common-iframe-sandbox,common-identity). TBDreact-dom/client. The root exports it, but there's a warning, though it works:Warning: You are importing createRoot from "react-dom" which is not supported. You should instead import it from "react-dom/client".