MQTT Helper Script uses always debian repos

[mutec]

✅ Have you read and understood the above guidelines?

yes

📜 What is the name of the script you are using?

MQTT

📂 What was the exact command used to execute the script?

bash -c "$(wget -qLO - https://github.com/community-scripts/ProxmoxVE/raw/main/ct/mqtt.sh)"

📝 Provide a clear and concise description of the issue.

When using the MQTT helper script with advanced settings you can choose whether to use Debian or Ubuntu.
In my case I'd want to use Ubuntu 24.04 which is accepted by the script and also successfully installed afterwards.

However during the installation script for Mosquitto a repository for APT is about to be added:

ProxmoxVE/install/mqtt-install.sh

Line 27 in a0f393c

echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/mosquitto-repo.gpg.key] http://repo.mosquitto.org/debian ${VERSION_CODENAME} main" >/etc/apt/sources.list.d/mosquitto.list

As you can see the url points statically to the debian repository, but reads the correct codename dynamically. In my case this would result in the following:
deb [arch= signed-by=/usr/share/keyrings/mosquitto-repo.gpg.key] http://repo.mosquitto.org/debian noble main
Since noble is a codename for Ubuntu, but not debian, this is about to fail.

According to the developer's site, it's not necessary to add an apt repository for Ubuntu, but for Debian:
https://mosquitto.org/download/
It is possible to add their dev PPA ppa:mosquitto-dev/mosquitto-ppa (see also https://launchpad.net/~mosquitto-dev/+archive/ubuntu/mosquitto-ppa) for more recent versions when using Ubuntu.
As you can see over here, it's truly available using the Ubuntu repositories:
https://packages.ubuntu.com/search?keywords=mosquitto&searchon=names&suite=all&section=all

⚙️ What settings are you using?

• Default Settings
• Advanced Settings

🖥️ Which Linux distribution are you using?

Ubuntu 24.04

🔄 Steps to reproduce the issue.

• Use Advanced Settings
• Set Distribution to Ubuntu
• Set Ubuntu Version to 24.04
• Run through the other settings (not relevant for this issue)

❌ Paste the full error output (if available).

n/a

🖼️ Additional context (optional).

No response

[michelroegl-brunner]

As stated everywhere. we do for now offer the option to change the OS, but we only support the default OS, in this case debian.

[mutec]

we do for now offer the option to change the OS, but we only support the default OS

What's the sense of the selection between both options if it's not supported at all?
I'd say Ubuntu would be more the "default OS" for mosquitto than Debian when reading phrases like "is now in Debian proper" or "available in the Ubuntu repositories so you can install as with any other package" on the developer's download instruction page.
In case you really won't fix the script (like it has already been done for MySQL in #3315), I'll have to set it up manually for our production containers.

[MickLesk]

#3300

[MickLesk]

And feel free to create a PR that fixes this "problem".