Skip to content

core: add var_os / var_version to whitelist for app.vars#12576

Merged
CrazyWolf13 merged 1 commit intomainfrom
os_selection_advanced_appdefaults
Mar 5, 2026
Merged

core: add var_os / var_version to whitelist for app.vars#12576
CrazyWolf13 merged 1 commit intomainfrom
os_selection_advanced_appdefaults

Conversation

@MickLesk
Copy link
Member

@MickLesk MickLesk commented Mar 5, 2026

✍️ Description

Include var_os and var_version in VAR_WHITELIST across load_vars_file, default_var_settings, and the global whitelist declaration. Also emit sanitized var_os and var_version in _build_current_app_vars_tmp so they are included in generated app variable output and can be recognized/persisted by the build tooling.

🔗 Related Issue

Fixes #12565

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Include var_os and var_version in VAR_WHITELIST across load_vars_file, default_var_settings, and the global whitelist declaration. Also emit sanitized var_os and var_version in _build_current_app_vars_tmp so they are included in generated app variable output and can be recognized/persisted by the build tooling.
@MickLesk MickLesk requested a review from a team as a code owner March 5, 2026 07:52
@CrazyWolf13 CrazyWolf13 merged commit 0f1a06c into main Mar 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants