Skip to content

Conversation

@havardthom
Copy link
Contributor

@havardthom havardthom commented Nov 8, 2024

Note

We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.

Description

Turnkey VM scripts have only had a bootdisk with ISO image, so people had to figure out themselves that another disk must be added to partition and install OS on. This issue caused Tteck to remove docs until more testing had been done: tteck/Proxmox#2351 (reply in thread)

This PR

  • Fixes Turnkey VM scripts by adding another disk for OS installation
  • Adds back documentation for Turnkey Nextcloud VM
  • Fixes documentation for Turnkey ownCloud VM
  • Fixes documentation for Jellyfin (crashes in production atm)
  • Changes unique script identifier in frontend from name to slug, because name is not unique (we have both Nextcloud VM and LXC). This will be a breaking change for id param in URL (if anyone have a script bookmarked), but it's better to do this change as early as possible. slug should always be unique since it is the same as script filename.

I am also planning on creating a Turnkey VM Install Guide in Github discussions to reference in documentation, since those VMs require a bootdisk installation process.

Fixes #93
Fixes tteck/Proxmox#2351 (reply in thread)

Type of change

Please check the relevant option(s):

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts.)
  • Documentation update required (this change requires an update to the documentation)

Prerequisites

The following efforts must be made for the PR to be considered. Please check when completed:

  • Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
  • Testing performed (I have tested my changes, ensuring everything works as expected)

Additional Information (optional)

Provide any additional context or screenshots about the feature or fix here.

hardware
partition-2
docs

@havardthom havardthom requested review from a team as code owners November 8, 2024 21:08
@MickLesk
Copy link
Member

MickLesk commented Nov 8, 2024

Looks okay for me

@BramSuurdje
Copy link
Member

LGTM

@havardthom havardthom merged commit 957f7e8 into community-scripts:main Nov 8, 2024
@havardthom havardthom deleted the fix-turnkey-vms branch November 14, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Turnkey Owncloud VM - stuck on partitioning

4 participants