Skip to content

Conversation

@MickLesk
Copy link
Member

@MickLesk MickLesk commented Sep 15, 2025

✍️ Description

small refactor of vm, added some improvements
switch to correct filename in json and vm
better network recognition in vm
better sleep recognition while sending lines
better handling of various storage types (tested with zfs, lvm, lvm-thin)

image

🔗 Related PR / Issue

Link: #7297

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Introduces a DISK_SIZE variable to allow setting disk size for OpenWrt VM in both default and advanced settings. Updates VM creation logic to use the specified disk size and improves output formatting for clarity.
@MickLesk MickLesk requested review from a team as code owners September 15, 2025 09:00
CrazyWolf13
CrazyWolf13 previously approved these changes Sep 15, 2025
@MickLesk MickLesk marked this pull request as draft September 15, 2025 09:19
Refactored network interface configuration to use a loop for more robust VM status checking and command delivery. Enhanced bridge interface setup with clearer messaging and improved variable handling. Minor shell syntax improvements for consistency.
@MickLesk MickLesk marked this pull request as ready for review September 15, 2025 09:30
@CrazyWolf13 CrazyWolf13 merged commit dffb291 into main Sep 15, 2025
5 checks passed
@MickLesk MickLesk deleted the openwrt branch September 23, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants