Adding function to join the breps when calling draw_breps()

[yck011522]

Feature Request

As a [user who build my own RhinoArtist for my custom geometry classes], I want [to create polysurfaces/joinnedBreps using the draw_breps() function] so that [benefit].

Details

Is your feature request related to a problem? Please describe.
Calling compas_rhino.utilities.drawing.draw_breps() with a list of input results in drawing multiple Breps. I want an option to create the the individual faces, join them, add them to doc and return the joined brep(s) guids.

Describe the solution you'd like
I think this can be backward compatible by using a flag.

[tomvanmele]

can you add an example script of a use case scenario?

[yck011522]

Yes, I can add an example to the docs to show that use case.

[tomvanmele]

no i mean can you add an example here to clarify the context of the requested functionality?

[yck011522]

Well, I added an example in the function's docs to show how to use: (check out the PR)

Using a compas Mesh as an example:
>>> from compas.datastructures import Mesh
>>> from compas.geometry import Box, Frame
>>> from compas_rhino.utilities import draw_breps
>>> box = Box(Frame.worldXY(), 1.0, 2.0, 3.0)
>>> mesh = Mesh.from_shape(box)
Draw convert each mesh face to brep dict schema:
>>> vertices = [mesh.vertex_attributes(vertex, 'xyz') for vertex in mesh.vertices()]
>>> breps = []
>>> for face in mesh.faces():
>>>     face = {'points' : [vertices[vertex] for vertex in mesh.face_vertices(face)]}
>>>     face['points'].append(face['points'][0])
>>>     breps.append(face)
Draw brep faces as one joined brep.
>>> guids = draw_breps(breps, join=True)

Context is a bit harder to say. Many times we need to model polysurfaces. One example is my timber beams with joint features. The features are 3d polygonal shapes. Not necessary extrusions, but can easily be modeled with polysurfaces composed of planar surfaces.

[yck011522]

Arh, another example is for instance, if the existing compas_rhino.artist.PolyhedronArtist wants to change it's implementation from drawing the polyhedron as RhinoMesh objects to drawing it as Rhino Polysurface objects.

Then you can simply use draw_breps(breps, join=True) as shown above to achieve it.

compas/src/compas_rhino/artists/polyhedronartist.py

Lines 45 to 82 in 75072d9

	def draw(self, show_vertices=False, show_edges=False, show_faces=True, join_faces=True):
	"""Draw the polyhedron associated with the artist.
	Parameters
	----------
	show_vertices : bool, optional
	Default is ``False``.
	show_edges : bool, optional
	Default is ``False``.
	show_faces : bool, optional
	Default is ``True``.
	join_faces : bool, optional
	Default is ``True``.
	Returns
	-------
	list
	The GUIDs of the objects created in Rhino.
	"""
	vertices = [list(vertex) for vertex in self.shape.vertices]
	guids = []
	if show_vertices:
	points = [{'pos': point, 'color': self.color, 'name': str(index)} for index, point in enumerate(vertices)]
	guids += compas_rhino.draw_points(points, layer=self.layer, clear=False, redraw=False)
	if show_edges:
	edges = self.shape.edges
	lines = [{'start': vertices[i], 'end': vertices[j], 'color': self.color} for i, j in edges]
	guids += compas_rhino.draw_lines(lines, layer=self.layer, clear=False, redraw=False)
	if show_faces:
	faces = self.shape.faces
	if join_faces:
	guid = compas_rhino.draw_mesh(vertices, faces, layer=self.layer, name=self.name, color=self.color, disjoint=True)
	guids.append(guid)
	else:
	polygons = [{'points': [vertices[index] for index in face], 'color': self.color} for face in faces]
	guids += compas_rhino.draw_faces(polygons, layer=self.layer, clear=False, redraw=False)
	self._guids = guids
	return guids