Skip to content

Conversation

@tomvanmele
Copy link
Member

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link
Member

@gonzalocasas gonzalocasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

For example, on Mac: ``'/Applications/Blender.app/Contents/Resources/2.83'``.
On Windows: ``'%PROGRAMFILES%/Blender Foundation/Blender 2.83/2.83'``.
version : {'2.83', '2.93'}, optional
version : {'2.83', '2.93', '3.1'}, optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think blender moves pretty fast with version numbers these days, maybe we need to look into how their versioning is defined and the support a more broad range (eg 3.x). But not in this PR.

For example, on Mac: ``'/Applications/blender.app/Contents/Resources/2.80'``.
On Windows: ``'%PROGRAMFILES%\\Blender Foundation\\Blender\\2.80'``.
For example, on Mac: ``'/Applications/Blender.app/Contents/Resources/2.83'``.
On Windows: ``'%PROGRAMFILES%/Blender Foundation/Blender 2.83/2.83'``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technicality but on windows, the only path separator that works is \

@tomvanmele tomvanmele merged commit 96ecee2 into main Mar 14, 2022
@tomvanmele tomvanmele deleted the blender-3_1 branch March 14, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants