-
Notifications
You must be signed in to change notification settings - Fork 113
Track guids in drawn objects #1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2dbaa98
track guids in drawn objects
Licini e579327
CHANGELOG
Licini 5b2703d
lint
Licini 3199f8d
Merge remote-tracking branch 'origin/main' into scene-object
Licini beb8084
use guids for compas_rhino
Licini 50be618
implement plane in Rhino
Licini 744113f
guids for GH
Licini 9d284a2
guids in blender
Licini 968a0df
lint
Licini 29f71f6
add PlaneObject to blender
Licini 322ebd9
fix docstring
Licini 8e83a7d
use clear plugin for both scene and scene object
Licini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ | |
|
|
||
|
|
||
| @pluggable(category="drawing-utils") | ||
| def clear(): | ||
| def clear(guids=None): | ||
| raise NotImplementedError | ||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
|
|
||
| from abc import abstractmethod | ||
| from .descriptors.protocol import DescriptorProtocol | ||
| from .context import clear | ||
|
|
||
|
|
||
| class SceneObject(object): | ||
|
|
@@ -13,14 +14,12 @@ class SceneObject(object): | |
| ---------- | ||
| item : Any | ||
| The item which should be visualized using the created SceneObject. | ||
| context : str, optional | ||
| Explicit context to pick the SceneObject from. | ||
| If not specified, an attempt will be made to automatically detect the appropriate context. | ||
|
|
||
|
|
||
| Attributes | ||
| ---------- | ||
| ITEM_SCENEOBJECT : dict[str, dict[Type[:class:`~compas.data.Data`], Type[:class:`~compas.scene.SceneObject`]]] | ||
| Dictionary mapping data types to the corresponding scene objects types per visualization context. | ||
| guids : list[object] | ||
| The GUIDs of the items drawn in the visualization context. | ||
|
|
||
| """ | ||
|
|
||
|
|
@@ -30,6 +29,11 @@ class SceneObject(object): | |
| def __init__(self, item, **kwargs): | ||
| self._item = item | ||
| self._transformation = None | ||
| self._guids = None | ||
|
|
||
| @property | ||
| def guids(self): | ||
| return self._guids or [] | ||
|
|
||
| @property | ||
| def transformation(self): | ||
|
|
@@ -52,7 +56,7 @@ def draw(self): | |
| """The main drawing method.""" | ||
| raise NotImplementedError | ||
|
|
||
| @staticmethod | ||
| def draw_collection(collection): | ||
| """Drawing method for drawing an entire collection of objects.""" | ||
| raise NotImplementedError | ||
| def clear(self): | ||
| """The main clearing method.""" | ||
| clear(guids=self.guids) | ||
| self._guids = None | ||
|
Comment on lines
-55
to
+62
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Then we also use same same |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomvanmele How about now? we collect the all guids of scene then clear all together. Also we add guids as argument for clear, so it does not delete the other stuff in context that are not managed by the scene.