Merge Graph into Network #1256
Merged
Merge Graph into Network #1256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomvanmele
requested review from
Licini,
chenkasirer,
gonzalocasas and
romanarust
tomvanmele
force-pushed
the
merge-graph-into-network
branch
from
4708ff2 to
9702d00
Compare
gonzalocasas
approved these changes
Jan 15, 2024
Member
gonzalocasas
left a comment
gonzalocasas
left a comment
There was a problem hiding this comment.
generally lgtm, although it's a lot of code for an in-depth review, but since most of it is just moved, I think the risk is minimal
Comment on lines
5
to
8
| from random import sample | ||
| from ast import literal_eval | ||
| from itertools import combinations | ||
|
|
Member
There was a problem hiding this comment.
i think imports need to be isorted
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| * Merged `compas.datastructures.Graph` into `compas.datastructures.Network`. |
Member
There was a problem hiding this comment.
Isn't it the other way around?
Suggested change
| * Merged `compas.datastructures.Graph` into `compas.datastructures.Network`. | |
| * Merged `compas.datastructures.Network` into `compas.datastructures.Graph`. |
Comment on lines
159
to
199
| :meth:`from_networkx` | ||
| :meth:`from_graphx` |
Member
There was a problem hiding this comment.
This is one search-n-replace too much, this is from_networkx still ;)
tests/compas/data/test_dataschema.py
Outdated
| ], | ||
| ) | ||
| def test_schema_graph_valid(graph): | ||
| def test_schema_graphalid(graph): |
| # ============================================================================== | ||
|
|
||
|
|
||
| def test_network_to_networkx(): |
Member
There was a problem hiding this comment.
Suggested change
| def test_network_to_networkx(): | |
| def test_graph_to_networkx(): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.