Scene.draw etc. #1275
Merged
Scene.draw etc. #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Licini
commented
Jan 25, 2024
src/compas/scene/scene.py
Outdated
|
|
||
| return drawn_objects | ||
|
|
||
| redraw = draw |
Contributor
Author
There was a problem hiding this comment.
But to be honest, I would even vote for not keep this alias, to distinct it from the redraw pluggable
Member
|
do we even need the redraw pluggable? rhino's redraw can be triggered by the postdraw hook... |
src/compas/scene/context.py
Outdated
|
|
||
|
|
||
| @pluggable(category="drawing-utils") | ||
| def predraw(): |
Member
There was a problem hiding this comment.
Docstrings to explain what these do?
Member
There was a problem hiding this comment.
@Licini and please add them to __init__ and to the api docs.
src/compas/scene/context.py
Outdated
|
|
||
|
|
||
| @pluggable(category="drawing-utils") | ||
| def postdraw(): |
Member
There was a problem hiding this comment.
If these are hooks, I would call them before_draw and after_draw
Contributor
Author
|
@tomvanmele All adjusted, take a final look? |
tomvanmele
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tomvanmele Changes you requested:
get_scene_object_clsso it will always be called.redrawtodraw, and kept it as alias.predrawandpostdraw.Data, as alternative solution to allow non-Data item in SceneObject #1274 .