Fix VolMesh delete cell

[tomvanmele]

What type of change is this?

• Bug fix in a backwards-compatible manner.
• New feature in a backwards-compatible manner.
• Breaking change: bug fix or new feature that involve incompatible API changes.
• Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
• I ran all tests on my computer and it's all green (i.e. invoke test).
• I ran lint on my computer and there are no errors (i.e. invoke lint).
• I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
• I have added tests that prove my fix is effective or that my feature works.
• I have added necessary documentation (if appropriate)

[tomvanmele]

@gonzalocasas needs a test and docs but perhaps you can already give this a try...

[tomvanmele]

from compas.datastructures import VolMesh

volmesh = VolMesh.from_meshgrid(9, 9, 9, 2, 1, 1)

print(volmesh)
print(volmesh._plane)

volmesh.delete_cell(0)

print(volmesh)
print(volmesh._plane)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.82%. Comparing base (663a05c) to head (0d96709).
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1406      +/-   ##
==========================================
+ Coverage   60.71%   60.82%   +0.11%     
==========================================
  Files         207      207              
  Lines       22268    22270       +2     
==========================================
+ Hits        13519    13545      +26     
+ Misses       8749     8725      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gonzalocasas]

Awesome, will review later today!

[gonzalocasas]

I tried this, but it still fails with a KeyError. Even the most minimal one:

from compas.datastructures import VolMesh
volmesh = VolMesh.from_meshgrid()
volmesh.delete_cell(0)

[tomvanmele]

weird, for me that works perfectly

from compas.datastructures import VolMesh

volmesh = VolMesh.from_meshgrid()

print(volmesh)
volmesh.delete_cell(0)
print(volmesh)

produces

<VolMesh with 1331 vertices, 3300 faces, 1000 cells, 3630 edges>
<VolMesh with 1331 vertices, 3297 faces, 999 cells, 3627 edges>

[tomvanmele]

@gonzalocasas please recheck because this is supposed to be fixed

[gonzalocasas]

LGTM! Thanks!!