Add make_solid method to RhinoBrep to cap planar holes

[papachap]

What type of change is this?

Adds make_solid() method to RhinoBrep for converting a brep to a solid if it is a strip in the Rhino backend.

• Bug fix in a backwards-compatible manner.
• New feature in a backwards-compatible manner.
• Breaking change: bug fix or new feature that involve incompatible API changes.
• Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
• I ran all tests on my computer and it's all green (i.e. invoke test).
• I ran lint on my computer and there are no errors (i.e. invoke lint).
• I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
• I have added tests that prove my fix is effective or that my feature works.
• I have added necessary documentation (if appropriate)

[chenkasirer]

I'm wondering if we shouldn't call this just cap_holes.
Wasn't able to fully understand but after having a look at the OCC implementation of make_solid() I'm not convinced these do the same thing.

[tomvanmele]

make_solid in compas_occ indeed does something else...

[obucklin]

I came to say the same thing. Is there another occ function that caps planar holes?

[tomvanmele]

there currently isn't a method that closes a hole in an existing brep, but this could be added...

[papachap]

@chenkasirer @tomvanmele @obucklin I now see my misconception, so thanks for pointing it out. I’ve renamed the method to cap_planar_holes() in compas_rhino.RhinoBrep and added it to compas.geometry.Brep.

[chenkasirer]

LGTM!