Feature/rhino object functions #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 18, 2019 22:52
…ng/remapping objects on surface
tomvanmele
requested changes
Feb 25, 2019
| The curve's length. | ||
| """ | ||
| return rs.CurveLength(self.guid) |
There was a problem hiding this comment.
the object is also stored, and there is a method of the object for getting the length...
https://developer.rhino3d.com/api/RhinoCommon/html/M_Rhino_Geometry_Curve_GetLength_2.htm
| """ | ||
|
|
||
| return rs.IsCurveClosed(self.guid) |
There was a problem hiding this comment.
src/compas_rhino/geometry/surface.py
Outdated
| The list of XYZ coordinates of surface boundary kinks. | ||
| """ | ||
|
|
src/compas_rhino/geometry/surface.py
Outdated
| """ | ||
|
|
||
| borders = self.borders(type = 0) |
src/compas_rhino/geometry/surface.py
Outdated
| borders = self.borders(type = 0) | ||
| proj_dist = {tuple(proj_xyz): distance_point_point(xyz, proj_xyz) for proj_xyz in [RhinoCurve(border).closest_point(xyz) for border in borders]} | ||
| delete_objects(borders) | ||
| return min(proj_dist, key = proj_dist.get) |
src/compas_rhino/geometry/surface.py
Outdated
| The XYZ coordinates of the re-mapped point. | ||
| """ | ||
|
|
src/compas_rhino/geometry/surface.py
Outdated
| The XYZ coordinates of the closest point on the boundaries of the surface. | ||
| """ | ||
|
|
| The XYZ coordinates of the closest point on the surface. | ||
| """ | ||
|
|
src/compas_rhino/geometry/surface.py
Outdated
|
|
||
| return rs.SurfaceClosestPoint(self.guid, xyz) + (0.,) | ||
|
|
||
| def remap_xyz_point(self, uv): |
src/compas_rhino/geometry/surface.py
Outdated
| Parameters | ||
| ---------- | ||
| uv : list | ||
| List of UV(0) coordinates. |
|
instead of wrapping rhinoscriptsyntax functions, is it better to wrap RhinoCommon functions or not wrapping anything and calling RhinoCommon methods directly? |
tomvanmele
approved these changes
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rhino curve and surface functions
curve length and is_closed
surface kinks, closest_point, closest_point_on_boundary and several mapping/remapping functions between XYZ and UV(0) spaces based on the surface's parameterisation