Skip to content

Update in plane.transform() to account for nested list #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romanarust merged 1 commit into from
Mar 8, 2019
Merged

Update in plane.transform() to account for nested list #261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/compas/geometry/_primitives/plane.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,8 @@ def transform(self, matrix):
The transformation matrix.

"""
point = transform_points([self.point], matrix)
normal = transform_vectors([self.normal], matrix)
point = transform_points([self.point], matrix)[0]
Copy link
Member

@gonzalocasas gonzalocasas Feb 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a bug? Does it fail without this change? Maybe you could add a little unit test for it (especially if it was failing before and your change fixes it)..

Copy link
Member

@gonzalocasas gonzalocasas Feb 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I just see the linked issue ;)

normal = transform_vectors([self.normal], matrix)[0]
self.point.x = point[0]
self.point.y = point[1]
self.point.z = point[2]
Expand Down